Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new username system #497

Merged
merged 6 commits into from
Jun 16, 2023
Merged

feat: new username system #497

merged 6 commits into from
Jun 16, 2023

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Jun 16, 2023

Description

Adds the new username pomelo update.

I also removed the bang from the mention of the user since it's been deprecated times ago.

Connected issues & other potential problems

discord/discord-api-docs#6218

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my changes haven't lowered code coverage

Copy link
Member

@l7ssha l7ssha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a changelog, and change version in constants and pubspec with new version (gonna be minor version). You can also change target branch to main directly

@l7ssha l7ssha changed the base branch from dev to main June 16, 2023 19:27
@l7ssha l7ssha added this to the 5.1 milestone Jun 16, 2023
@l7ssha l7ssha merged commit 9e7b2e8 into main Jun 16, 2023
@l7ssha l7ssha deleted the feat/pomelo branch June 16, 2023 19:47
@Lexedia Lexedia self-assigned this Jun 20, 2023
@Lexedia Lexedia added the enhancement New feature or request label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants