fix safe_edit variables

nyxnor · Feb 16, 2022 · 32d78f5 · 32d78f5
1 parent 8d54cf9
commit 32d78f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/configure.sh b/configure.sh
@@ -162,7 +162,7 @@ make_shellcheck(){
   command -v shellcheck >/dev/null || error_msg "Install shellcheck to review syntax"
   notice "${yellow}Checking shell syntax${nocolor}"
   ## Customize severity with -S [error|warning|info|style]
-  if ! shellcheck configure.sh etc/onionjuggler/*.conf usr/bin/*; then
+  if ! shellcheck "${topdir}"/configure.sh "${topdir}"/etc/onionjuggler/*.conf "${topdir}"/usr/bin/*; then
     error_msg "Please fix the shellcheck warnings above before pushing!"
   fi
 }

diff --git a/usr/bin/onionjuggler-cli b/usr/bin/onionjuggler-cli
@@ -302,7 +302,7 @@ safe_edit(){
   [ -w "${TMPDIR:="/tmp"}" ] || export TMPDIR="~"
   TMPDIR="${TMPDIR%*/}"
   key="${2}"
-  eval file=$(printf '%s\n' "${key}")
+  eval file="$(printf '%s\n' '$'"${key}")"
   case "${1}" in
     tmp)
       file_name_tmp="$(mktemp "${TMPDIR}/${file##*/}.XXXXXX")"