Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned comment with trajectory arguments #395

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

gregjesl
Copy link
Contributor

@gregjesl gregjesl commented Jan 2, 2025

Summary

Fixes mismatch between comments and implementation

Architectural Changes

No change

New Features

No change

Improvements

No change

Bug Fixes

No change

Testing and validation

No change to code

Documentation

Original comment stated

// We'll arbitrarily set the tracking arc to 48 hours with a one minute time step.

but actual arguments are
5.seconds(),
Some(Epoch::from_str("2024-01-01 00:00:00 UTC")?),
Some(Epoch::from_str("2024-01-02 00:00:00 UTC")?),

which is a five-second interval over 24 hours, not a one-minute interval over 48 hours.

@ChristopherRabotin
Copy link
Member

Good catch, thanks!

@ChristopherRabotin ChristopherRabotin merged commit 0f9ed48 into nyx-space:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants