Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed der dependency #297

Merged
merged 3 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ jobs:
- name: Test (default features)
run: cargo test

- name: Test (ASN1)
run: cargo test --features asn1der

- name: Test (UT1)
run: cargo test --features ut1

Expand Down Expand Up @@ -120,8 +117,8 @@ jobs:
- name: Generate coverage report
run: |
cargo llvm-cov clean --workspace
cargo llvm-cov test --no-report --features=std,asn1der -- --test-threads=1
cargo llvm-cov test --no-report --tests --features=std,asn1der -- compile_fail
cargo llvm-cov test --no-report --features=std -- --test-threads=1
cargo llvm-cov test --no-report --tests --features=std -- compile_fail
cargo llvm-cov report --lcov > lcov.txt
env:
RUSTFLAGS: --cfg __ui_tests
Expand Down
4 changes: 1 addition & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ name = "hifitime"
[dependencies]
serde = { version = "1.0.155", optional = true }
serde_derive = { version = "1.0.155", optional = true }
der = { version = "0.7.8", features = ["derive", "real"], optional = true }
pyo3 = { version = "0.21.1", features = [
"extension-module",
"inventory",
Expand Down Expand Up @@ -72,8 +71,7 @@ iai = "0.1"
[features]
default = ["std"]
std = ["serde", "serde_derive", "web-time"]
asn1der = ["der"]
python = ["std", "asn1der", "pyo3", "ut1"]
python = ["std", "pyo3", "ut1"]
ut1 = ["std", "reqwest", "tabled", "openssl"]

[[bench]]
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ In order to provide full interoperability with NAIF, hifitime uses the NAIF algo
+ Minimum Support Rust Version (MSRV) bumped to 1.77.0
+ Major refactoring of the code for ease of maintenance and removal of deprecrated functions from 3.x
+ Centralization of all time scale conversions into the `to_time_scale` function -- huge effort by [@gwbres](https://github.com/gwbres)
+ Removed `der` encoding/decoding for Epoch and Duration.

## 3.9.0

Expand Down
154 changes: 0 additions & 154 deletions src/asn1der.rs

This file was deleted.

3 changes: 0 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ pub mod prelude {
};
}

#[cfg(feature = "asn1der")]
pub mod asn1der;

#[cfg(feature = "python")]
pub mod python;

Expand Down
Loading