Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LeapSecondsFile and UT1 #194

Merged

Conversation

ChristopherRabotin
Copy link
Member

@cjordan This PR adds (initial) support for UT1. It does not make UT1 a TimeScale, but it allows conversion to and from UT1 into other time scales. It also automatically downloads the Earth Orientation Parameters from JPL if needed, or it can read an EOP data from the provided path. This requires the ut1 crate feature.

Closes #43

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 77.67% // Head: 79.40% // Increases project coverage by +1.72% 🎉

Coverage data is based on head (ae1d94c) compared to base (b1071b9).
Patch coverage: 70.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   77.67%   79.40%   +1.72%     
==========================================
  Files          14       16       +2     
  Lines        3602     3686      +84     
==========================================
+ Hits         2798     2927     +129     
+ Misses        804      759      -45     
Impacted Files Coverage Δ
src/errors.rs 37.50% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/leap_seconds.rs 60.71% <60.71%> (ø)
src/leap_seconds_file.rs 65.21% <65.21%> (ø)
src/efmt/format.rs 88.88% <100.00%> (+9.33%) ⬆️
src/epoch.rs 87.73% <100.00%> (+0.06%) ⬆️
src/efmt/formatter.rs 74.71% <0.00%> (+24.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Also remove the Kani visualizations -- if it fails I run it in VSCode or locally

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
@ChristopherRabotin ChristopherRabotin merged commit 69673d2 into master Dec 30, 2022
@ChristopherRabotin ChristopherRabotin deleted the 43-allow-to-ignore-leap-seconds-after-a-given-date branch December 30, 2022 16:01
@cjordan
Copy link
Contributor

cjordan commented Dec 31, 2022

Thanks @ChristopherRabotin ! I'll have a look at massaging this new functionality into our crates when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to ignore leap seconds after a given date
3 participants