Extend formal verification #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Thanks kani! In some cases, there was a risk to an overflow in either the multiplication or addition. I thought that the code handled that, but obv it didn't. Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Codecov ReportBase: 0.00% // Head: 79.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
===========================================
+ Coverage 0 79.83% +79.83%
===========================================
Files 0 10 +10
Lines 0 2886 +2886
===========================================
+ Hits 0 2304 +2304
- Misses 0 582 +582
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Currently when the test fail I can't easily debug the case that caused a failure Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Also remove an assert in src code. Formal verification means that isn't needed. Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
…cations Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
It should be centered on zero, but the current implementation does not do that (and kani catches it). Anyway, this needs to be fixed. Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Also added much needed documentation on how negative durations work, even I had forgotten how it was setup.
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
| @@ -284,6 +284,14 @@ In order to provide full interoperability with NAIF, hifitime uses the NAIF algo | |||
|
|
|||
| # Changelog | |||
|
|
|||
| ## 3.8.0 | |||
There was a problem hiding this comment.
This is a work in progress, but I'm adding this to not forget the release notes.
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
It does not complete on my machine. I will need to find another formulation for it. Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
|
Woohoo! All of the formal verification passes! Will merge now. |
ChristopherRabotin
deleted the
184-greatly-improve-formal-verification-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #184 for progress.
Implements #184
List of bugs fixed thanks to Kani:
normalize()in Duration (which is called after every operation on a Duration) could overflow near the maximum or minimum number of centuries when the nanoseconds were still within the MIN/MAX of the structure.normalize()in Duration would overflow when the duration was near (but below) the MAXDuration::neg()would overflow near MIN/MAXPartialEqonDurationwould overflow near MIN/MAXtry_truncated_nanosecondswould overflow on any duration where the input was larger than the MAXOps::Addwould fail when the centuries was thei16::MINbut the nanoseconds were still validOps::Addwould overflow when the right hand side input was not normalizedOps::Subwould underflow when subtracting a duration whose nanoseconds was greater thanselfand whenself.centurieswas near the MIN.