Methods renamed to be idiomatic #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Duration: Rename in_seconds and in_unit to to_seconds and to_unit + Duration: add initializers from all units without the need of Unit
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Must update tests now (clippy will be upset) Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Closes #155 Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
Codecov ReportBase: 75.13% // Head: 78.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 75.13% 78.75% +3.62%
==========================================
Files 9 9
Lines 2433 2349 -84
==========================================
+ Hits 1828 1850 +22
+ Misses 605 499 -106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
ChristopherRabotin
deleted the
155-addreplace-methods-to-be-more-rust-idiomatic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155