Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.1 -- usability enhancement #118

Closed
2 tasks done
ChristopherRabotin opened this issue Mar 30, 2022 · 2 comments
Closed
2 tasks done

v3.1 -- usability enhancement #118

ChristopherRabotin opened this issue Mar 30, 2022 · 2 comments
Assignees
@ChristopherRabotin
Milestone
Version 3.2.0

Comments

@ChristopherRabotin
Copy link
Member

ChristopherRabotin commented Mar 30, 2022 •
edited
Loading

  • All Enums should be Copy, PartialEq, PartialOrd, Ord, Eq, Clone. TimeSystem (and likely other enums) are not copy. That's frustrating.
  • Epoch should derive Eq, Ord
@ChristopherRabotin ChristopherRabotin self-assigned this Mar 30, 2022
@ChristopherRabotin ChristopherRabotin changed the title All Enums should be Copy v3.1 -- usability enhancement Mar 30, 2022
@ChristopherRabotin ChristopherRabotin added this to the Version 3.2.0 milestone May 3, 2022
@ChristopherRabotin ChristopherRabotin mentioned this issue May 19, 2022
Merged
3 tasks
@mkolopanis
Copy link
Contributor

Should Epoch derive Ord? It looks like it only derives PartialOrd still even in v3.2.

@ChristopherRabotin
Copy link
Member Author

ChristopherRabotin commented Jul 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherRabotin ChristopherRabotin

Labels
None yet
Projects
None yet
Milestone
Version 3.2.0
Development

No branches or pull requests
2 participants
@ChristopherRabotin @mkolopanis