Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIC computation reverted to standard approach #221

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

ChristopherRabotin
Copy link
Member

Summary

The RIC frame was using a less commonly used method. Thinking about this some more, I think it was wrong in that the R vector had the wrong direction, and I think that the formulation I originally had was for the Hill frame (tbc).

Architectural Changes

Add dependency on https://github.com/thebashpotato/egui-aesthetix for GUI theming.

New Features

No change

Improvements

No change

Bug Fixes

  • RIC frame computation changed to literature standard, and documentation updated to reflect that. To compute the time derivative of the RIC frame, the finite differencing of the DCM is computed by assuming two body dynamics for one second before and after the current state.

Testing and validation

No actual change in the test since it only checks the reciprocity of the RIC frame rotation. Manually however, I checked that the RIC velocity magnitude was reasonable: prior to this change, the magnitude of the velocity on the i axis was 70 km/s which didn't seem to make much sense at all. Reverting to the lit standard shows that the velocity in RIC is significantly lower, and that makes more sense for the physical definition of the RIC frame.

Documentation

This PR does not primarily deal with documentation changes.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.66%. Comparing base (12df704) to head (74ca711).

Files Patch % Lines
anise/src/astro/orbit.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   79.73%   79.66%   -0.07%     
==========================================
  Files          72       72              
  Lines        8765     8775      +10     
==========================================
+ Hits         6989     6991       +2     
- Misses       1776     1784       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 32d908b into master Apr 3, 2024
21 of 22 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 191-bis branch April 3, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant