RIC computation reverted to standard approach #221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The RIC frame was using a less commonly used method. Thinking about this some more, I think it was wrong in that the R vector had the wrong direction, and I think that the formulation I originally had was for the Hill frame (tbc).
Architectural Changes
Add dependency on https://github.com/thebashpotato/egui-aesthetix for GUI theming.
New Features
No change
Improvements
No change
Bug Fixes
Testing and validation
No actual change in the test since it only checks the reciprocity of the RIC frame rotation. Manually however, I checked that the RIC velocity magnitude was reasonable: prior to this change, the magnitude of the velocity on the
i
axis was 70 km/s which didn't seem to make much sense at all. Reverting to the lit standard shows that the velocity in RIC is significantly lower, and that makes more sense for the physical definition of the RIC frame.Documentation
This PR does not primarily deal with documentation changes.