404 page #96
Merged
404 page #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noslouch
pushed a commit
that referenced
this pull request
Apr 19, 2017
…-link-underline WE-6859 Update notification link style
noslouch
commented
Apr 24, 2017
app/styles/_error.scss
Outdated
| min-height: 100vh; | ||
|
|
||
| height: 100vh; | ||
| margin-bottom: -2.4rem; |
There was a problem hiding this comment.
is this why? I thought the margin was due to a margin top on the site-chrome-footer?
noslouch
force-pushed
the
brian-WE-7045
branch
2 times, most recently
from
22b2e06
to
e5454c0
Compare
on dev it's http://locahost:4200 in testing it's / when deplying to production or demo it's the FINGERPRINT_PREPEND_URL envvar provided by circle, either static.wqxr.org or demo-static.wqxr.org, respectively
don't need staticHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE-7045
updates the
error-pagecomponent and adds astaticHostconfig var to supply the fully-qualified path to the jpeg.