Listen Live Chunk on wqxr series #86
Conversation
| @@ -28,9 +28,9 @@ | |||
| {{/alt-channel-layout}} | |||
| {{else}} | |||
| {{#if model.channel.hasMarquee}} | |||
| {{x-marquee model=model.channel isStaff=session.data.isStaff adminURL=adminURL}} | |||
| {{x-marquee listenLive=model.listenLive.pagecontent model=model.channel isStaff=session.data.isStaff adminURL=adminURL}} | |||
There was a problem hiding this comment.
I don't actually know the answer to this question, so I'm just throwing it out: would bad things happen if listenLive was '' (because the show chunk didn't exist), and you subsequently try to access an attr? Console error or...? Should there be a default chunk like shows-default-listenlive that gets used if the show chunk doesn't exist?
There was a problem hiding this comment.
excellent question; answered by the tests. I create a listen live chunk on one test only; the others do not retrieve one and seem to render fine.
This can be tested on demo as well by loading up any show that isn't Q2. Ember is fairly forgiving when it comes to accessing keys on undefined values on templates, but not so much in JS files.
might be getting time to refactor these components to produce more sensible yields
also whitespace
WE-7096
looks up a chunk according to the convention
shows-<slug>-listenliveand renders it in thechannel-headerif something comes back.