Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player vqa #34

Merged
merged 2 commits into from
Apr 3, 2017
Merged

player vqa #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e888f4
player vqa
dparrington Mar 23, 2017
a22b05f
don't need line-heights with removal of screen.css
dparrington Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/nypr-player-integration/stream-info/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@
data-tracking-action='Click Through to Music Playlist'
data-tracking-label='{{stream.name}}'>MUSIC PLAYLIST</a>
{{/if}}
{{#link-to 'stream' (query-params modal='null') title='All Live Streams'}}ALL LIVE STREAMS{{/link-to}}
{{#link-to 'stream' (query-params modal='null') title='All Streams'}}ALL STREAMS{{/link-to}}
</span>
2 changes: 1 addition & 1 deletion app/styles/_nypr-player-overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ $wnyc-player-link-color : #77A6DE;

a {
font-weight: 700;
margin-right: 5px;
margin-right: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dparrington Were the changes made on this done before we removed screen.css from publisher? I'm wondering why we need to make some CSS changes to the player (and why it doesn't look like WNYC right off the bat).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marineb I believe this was done after the removal of screen.css. Not sure what makes the css different from WNYC. The line-height edits are to match WNYC, but the extra margin between the links is just WQXR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dparrington is there anyway that change could be managed in the player repo? If so, let's do that? If not, @alisonm would you mind creating a ticket so we mirror those changes on WNYC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marineb I could probably move this over to the player repo as long as you are ok with using the 10px margin between links on wnyc too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dparrington yes sounds good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this also going to be applied to wnyc-web-client?

color: $wnyc-player-link-color;

&:hover {
Expand Down