Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wqxr dfpTargeting #116

Merged
merged 4 commits into from
Apr 24, 2017
Merged

wqxr dfpTargeting #116

merged 4 commits into from
Apr 24, 2017

Conversation

noslouch
Copy link
Contributor

Brian Whitton added 4 commits April 24, 2017 18:05
adds assertions for DFP targeting
15f7ac3 
on the following routes:
`djangorendered`
`playlist`: /streams/<slug>/
`schedule`: /schedule/<date>/?scheduleStation=<slug>
`shows`: /shows
`streams`: /streams
`channels`: /shows|series|articles|blogs|tags/<slug>
adds home page test
2225307 
moves home tests out of django rendered and adds dfp targeting test
do targeting on these routes
b194a85
updates schedule acceptance test
9c50384
@noslouch noslouch merged commit 379cc1c into master Apr 24, 2017
@noslouch noslouch deleted the brian-WE-7302 branch April 24, 2017 22:19
noslouch pushed a commit that referenced this pull request Apr 25, 2017
Merge pull request #116 from nypublicradio/brian-WE-7055
8960518 
use breakpoints for leaderboard ads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walsh9 walsh9 walsh9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noslouch @walsh9