Refactor bricks #39
Merged
Refactor bricks #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noslouch
force-pushed
the
nypr-card-refactors
branch
from
91133df
to
b592557
Compare
noslouch
force-pushed
the
refactor-bricks
branch
from
d800734
to
79f1fbf
Compare
mike-hearn
approved these changes
Apr 10, 2017
noslouch
force-pushed
the
nypr-card-refactors
branch
from
6b7ba67
to
8394128
Compare
added 18 commits
April 10, 2017 12:53
nypr card refactors
this will be resurrected as brick-row-blowout
layout, formatting, and use of component attributes also allow for yielding a block
so it can be used as-is in the template on other elements
noslouch
force-pushed
the
refactor-bricks
branch
from
26672a4
to
e48837a
Compare
mike-hearn
reviewed
Apr 10, 2017
| export default Ember.Component.extend({ | ||
| layout, | ||
| classNames: ['row__col'], | ||
| classNameBindings: ['flipped'] |
There was a problem hiding this comment.
Looks like there may be a small attribute name inconsistency between flip vs. flipped - on this component, if you pass flipped=true it would get flipped, but down on nypr-brick-row-blowout.hbs (https://github.com/nypublicradio/nypr-ui/pull/39/files#diff-6141847a1a5efc27761d45f7bd66729fR9), it checks for flip=true.
I think if this line was written as classNameBindings: ['flip:flipped'] they would both simply require flip=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
nypr-brick-layoutto expose a few levels of contextual components, which should make it easier for upstream apps to arbitrarily replace and re order parts of the layout.One thing worth noting is that this renames
nypr-brick-image-rowtonypr-brick-row-blowout, so it has a naming that's more consistent with the convention we've set up.