Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hvac to 1.1.0. #18

Closed
wants to merge 2 commits into from
Closed

Conversation

area42
Copy link
Contributor

@area42 area42 commented May 26, 2023

In our project we need hvac 1.10 for some other dependencies

  • pytest runs clean.
  • review hvac release nodes lists no relevant breaking changes AFAIK

area42 added 2 commits May 26, 2023 14:39
pytest runs clean.
review hvac release nodes lists no relevant breaking changes AFAIK
nymous added a commit that referenced this pull request Aug 24, 2023
Because we are a library and not an end application, we need to relax
our dependencies, so that our users have the most leeway to choose the
version of our sub-dependencies that they want (for example if they have
hvac as a direct dependency or if another of their dependencies has hvac
as a sub-dependency).
By leaving the upper constraint open (we just want hvac >= 0.10.6),
users can keep the "old" version they already had, or use a newer
version if they want/have to (because of a sub-dependency). If a later
hvac version breaks pydantic-vault, user can always pin the
sub-dependency version to something that works with all their
dependencies...

This was initially implemented by @area42 in PR #18, I redid it on top
of the new main branch because I changed all other dependency versions
and there was too many conflicts ^^' Thank you for your contribution!

Supersedes: #18

Co-authored-by: Mike Wessling <mwessling@gmail.com>
@nymous
Copy link
Owner

nymous commented Aug 25, 2023

Hello @area42!
Thank you for your contribution! It was indeed something that I wanted to do, after learning more about how to be a "nice" library and play well with others ^^
Because I took the project back to an installable state first, bumping all dependencies, your PR had conflicts that would have been too hard to resolve. I instead applied your change in #23, and credited you both in the commit message as co-author and in the changelog. Hope you don't mind!

Very sorry for the delay 😬 I hope to release a new version in the following days (this weekend?) so you can play with it and confirm it works.

@nymous nymous closed this Aug 25, 2023
@area42 area42 deleted the patch/bump-hvac-to-1.1.0 branch August 25, 2023 14:15
@nymous
Copy link
Owner

nymous commented Sep 10, 2023

Release 0.8.0 is out with this!
Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants