feat: require explicit secret path & support any secret engine #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use different secret mount points in the same configuration, as well as support engines other than KV v2. With it also comes the possibility to load an entire secret at once, by not passing a `vault_secret_key`. BREAKING CHANGE: This requires that you explicitely pass the full secret path, eg. `secret/data/<path/to/secret>` for a KV v2, or `database/creds/<your DB role>` for a database engine.
nymous
force-pushed
the
explicit-secret-path
branch
from
0d9e5c3 to
f2da05d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use different secret mount points in the same configuration, as well as support engines other than KV v2.
With it also comes the possibility to load an entire secret at once, by not passing a
vault_secret_key.BREAKING CHANGE: This requires that you explicitely pass the full secret path, eg.
secret/data/<path/to/secret>for a KV v2, ordatabase/creds/<your DB role>for a database engine.