Update Facebook API version to v18.0 #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 74.52% 74.52%
=======================================
Files 111 111
Lines 13221 13223 +2
=======================================
+ Hits 9853 9855 +2
Misses 2651 2651
Partials 717 717 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
update-FB-API-version
branch
from
2221b28 to
7c336ee
Compare
norkans7
commented
Dec 12, 2024
| @@ -155,6 +156,10 @@ func getAttachmentType(t *httpx.Trace) (string, string) { | |||
| extensions, err := mime.ExtensionsByType(typ) | |||
| if len(extensions) > 0 && err == nil { | |||
| ext = extensions[0][1:] | |||
| if slices.Contains([]string{"jpe", "jfif"}, ext) { | |||
There was a problem hiding this comment.
This was returning different extensions but they are the same format so I used this workaround until I find why the mimetypes dependency we use is not consistent there
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.