Add librato logging #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
approved these changes
Aug 21, 2017
| } | ||
|
|
||
| // our buffer is full, log an error but continue | ||
| if len(c.buffer) >= cap(c.buffer) { |
There was a problem hiding this comment.
Does this need to be behind a mutex so two threads can't both get the all clear to to add to the buffer when it's only got room for one more item?
There was a problem hiding this comment.
Maybe, but the idea is to avoid mutexes as much as possible with channels. We really should never reach this point as the buffer size should keep us ahead. If for some reason we do go beyond this, what will happen is the push unto the channel will block until our other goroutine flushes, so it isn't the end of the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at a bunch of libraries to do this but they were all sucky in one way or another. Boo.