Add support for YO! and SMS Central channels #31
Conversation
norkans7
changed the title
handlers/smscentral/smscentral.go
Outdated
| // Initialize is called by the engine once everything is loaded | ||
| func (h *handler) Initialize(s courier.Server) error { | ||
| h.SetServer(s) | ||
| s.AddReceiveMsgRoute(h, "POST", "receive", h.ReceiveMessage) |
There was a problem hiding this comment.
These should be checking error status and returning them if non-nil
handlers/smscentral/smscentral.go
Outdated
| func (h *handler) Initialize(s courier.Server) error { | ||
| h.SetServer(s) | ||
| s.AddReceiveMsgRoute(h, "POST", "receive", h.ReceiveMessage) | ||
| s.AddReceiveMsgRoute(h, "GET", "receive", h.ReceiveMessage) |
There was a problem hiding this comment.
Let's figure out which SMS Central uses and only support that one.
handlers/smscentral/smscentral.go
Outdated
| func (h *handler) SendMsg(msg courier.Msg) (courier.MsgStatus, error) { | ||
| username := msg.Channel().StringConfigForKey(courier.ConfigUsername, "") | ||
| if username == "" { | ||
| return nil, fmt.Errorf("no username set for KN channel") |
handlers/smscentral/smscentral.go
Outdated
| return status, err | ||
| } | ||
|
|
||
| if rr.StatusCode != 200 && rr.StatusCode != 201 && rr.StatusCode != 202 { |
There was a problem hiding this comment.
rr.StatusCode / 100 != 2?
handlers/yo/yo.go
Outdated
| // Initialize is called by the engine once everything is loaded | ||
| func (h *handler) Initialize(s courier.Server) error { | ||
| h.SetServer(s) | ||
| s.AddReceiveMsgRoute(h, "POST", "receive", h.ReceiveMessage) |
There was a problem hiding this comment.
Check error status, lets only register what these guys currently use. (look at our logs to figure out)
handlers/yo/yo.go
Outdated
| failed = true | ||
| } | ||
|
|
||
| if failed == false && rr.StatusCode != 200 && rr.StatusCode != 201 { |
There was a problem hiding this comment.
Maybe see if you can refactor this a bit with continues instead of checking failed everywhere
There was a problem hiding this comment.
By using continue we won't be able to stop blacklisted contacts
| @@ -1,6 +1,119 @@ | |||
| package smscentral | |||
There was a problem hiding this comment.
Add tests for smscentral.
|
I have updated to only add handler for the requests we get for each channel type |
No description provided.