Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sending support to courier, plug in sentry, log request and respo… #11

Merged
merged 11 commits into from
Jul 5, 2017

Conversation

nicpottier
Copy link
Collaborator

…nse for all incoming/outgoing msgs

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.8%) to 57.844% when pulling 45eb520 on sending into 7b13ed7 on master.

…ent twilio, kannel, AT and BM channels for sending
@coveralls
Copy link

Coverage Status

Coverage decreased (-15.3%) to 52.314% when pulling d3c3677 on sending into 7b13ed7 on master.

Copy link
Member

@rowanseymour rowanseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot in here but it looks good.

Have been thinking about where the responsbility should lie for activating/deactivating channels - e.g. creating callbacks. Let's discuss that sometime.

@@ -8,13 +8,28 @@ import (
)

const (
// ConfigAuthToken is our constant key used in channel configs for auth tokens
// ConfigAuthToken is a constant key for channel configs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how useful it is trying to make channel configs conform to any schema

@rowanseymour
Copy link
Member

Coverage down 15% tsk tsk

@nicpottier
Copy link
Collaborator Author

Who needs tests!?! Ya, testing is next, just wanted to cover all the use cases first.

You are talking about who calls Twilio to register the callbacks? Feels like that's a RapidPro responsibility to me but open to discussing it.

@rowanseymour
Copy link
Member

Agree that the responsibility lies with RapidPro - see comment on nyaruka/rapidpro#1322 for what I was thinking about activating/deactivating channels

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 64.738% when pulling 161df8e on sending into 7b13ed7 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 66.274% when pulling c157b9f on sending into 7b13ed7 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 68.0% when pulling 7b2ea69 on sending into 7b13ed7 on master.

@nicpottier nicpottier merged commit d1c351f into master Jul 5, 2017
@nicpottier nicpottier deleted the sending branch July 5, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants