-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sending support to courier, plug in sentry, log request and respo… #11
Conversation
…nse for all incoming/outgoing msgs
…ent twilio, kannel, AT and BM channels for sending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot in here but it looks good.
Have been thinking about where the responsbility should lie for activating/deactivating channels - e.g. creating callbacks. Let's discuss that sometime.
@@ -8,13 +8,28 @@ import ( | |||
) | |||
|
|||
const ( | |||
// ConfigAuthToken is our constant key used in channel configs for auth tokens | |||
// ConfigAuthToken is a constant key for channel configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how useful it is trying to make channel configs conform to any schema
Coverage down 15% tsk tsk |
Who needs tests!?! Ya, testing is next, just wanted to cover all the use cases first. You are talking about who calls Twilio to register the callbacks? Feels like that's a RapidPro responsibility to me but open to discussing it. |
Agree that the responsibility lies with RapidPro - see comment on nyaruka/rapidpro#1322 for what I was thinking about activating/deactivating channels |
…nse for all incoming/outgoing msgs