1.2.2 #11
Merged
1.2.2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 14, 2023 03:44
- updated
- remove unnecessary coroutine scope
…Item, OverwriteDefaultsDialog, LoadWithOptionsDialog, DefaultThemesButtons, EditorScreen, ChatScreenThemePreview, MainScreen, Navigator): - some refactoring - added a view model factry MainActivity: - initializing the view model using the factory ChatScreenPreview: - removed compose preview
- changes to how context is passed and how it is used
- added MainViewModel (affects EditorTopAppBar, ElementColorItem): - moved some stuff to ThemeRepository, moved getThemeAsStringByUUID() inside the viewmodel - stuff related to loading, saving, updating themes has been refactored a bit
- fixed replaceThemeByUUID functioning
- changed behavior oof the startupConfigProcess. now if a default theme is absent (on first launch, for example) - a default theme will be created using a stock theme which means it will not load the themes from the assets folder on each launch when user has not overridden a default theme
- added updateDefaultDarkThemeFromStock() - added updateDefaultLightThemeFromStock() MainScreen: - now tracking if the stock themes were changed and asking to update them (by displaying a dialog and showing options in the drop down menu) if they were. initial implementation ofc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.