Don't overwrite all options previously specified when manifest is found (assign re-defined only)

[Black-Platypus]

Keep anything the user specified in the options object and only overwrite things found in any manifest (package.json) found.

• Assign manifest.app to options.app
• Assign manifest to options
• Restore options.app

Fixes: #1261

[ayushmanchhabra]

I remember why I did this. If options.srcDir or options.glob is undefined, then getNodeManifest function will throw an error. This is why the parse function is called twice. If there's a better way to go about this, I'm all ears

[ayushmanchhabra]

@Black-Platypus ping

[ayushmanchhabra]

Keep anything the user specified in the options object and only overwrite things found in any manifest (package.json) found.

Also nothing should be overwritten. If an option is undefined, the default value is used for it. If an option is being overwritten, then its probably an error in the parse function.

[Black-Platypus]

Keep anything the user specified in the options object and only overwrite things found in any manifest (package.json) found.

Also nothing should be overwritten. If an option is undefined, the default value is used for it. If an option is being overwritten, then its probably an error in the parse function.

This completely overwrites options, no? Am I overlooking something?

nw-builder/src/index.js

Line 50 in ef120b2

options = manifest.nwbuild;

[ayushmanchhabra]

Keep anything the user specified in the options object and only overwrite things found in any manifest (package.json) found.

Also nothing should be overwritten. If an option is undefined, the default value is used for it. If an option is being overwritten, then its probably an error in the parse function.

This completely overwrites options, no? Am I overlooking something?

nw-builder/src/index.js

Line 50 in ef120b2

options = manifest.nwbuild;

The options defined in a package.json (NW.js manifest) overwrite options defined in JavaScript API or CLI. The highlighted code checks if the options are defined in package.json. This is a feature not bug.

[Black-Platypus]

Alright, sad to hear this won't be implemented.
(It felt wrong to discard information specifically set in JS or CLI just because I want to pass in some values via manifest)

[ayushmanchhabra]

I'm not against this but it would be a breaking change. Also having a priority makes it easier to maintain in the long term