Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): handle boolean type options correctly #1255

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Oct 2, 2024

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 32.07% 536 / 1671
🔵 Statements 32.07% 536 / 1671
🔵 Functions 36.66% 11 / 30
🔵 Branches 63.15% 24 / 38
File CoverageNo changed files found.
Generated in workflow #942 for commit 3c30a0c by the Vitest Coverage Report Action

@ayushmanchhabra ayushmanchhabra changed the title fix(cli): add definitions fix(cli): handle boolean type options correctly Oct 31, 2024
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review October 31, 2024 07:53
@ayushmanchhabra ayushmanchhabra merged commit 524fe34 into main Oct 31, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the fix/cli branch October 31, 2024 07:54
ayushmanchhabra pushed a commit that referenced this pull request Nov 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.11.5](v4.11.4...v4.11.5)
(2024-11-01)


### Bug Fixes

* **cli:** handle boolean type options correctly
([#1255](#1255))
([524fe34](524fe34)),
closes [#1277](#1277)


### Chores

* **deps-dev:** bump nw from 0.92.0 to 0.93.0 in the npm group across 1
directory ([#1289](#1289))
([ed275ad](ed275ad))
* **deps:** bump the gha group across 1 directory with 2 updates
([#1285](#1285))
([13081c9](13081c9))
* **docs:** clarify priority for defined options
([#1281](#1281))
([632db41](632db41)),
closes [#1261](#1261)
* **docs:** improve terminology
([84fa2a4](84fa2a4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: unknown option '--mode=build'
1 participant