Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump the npm group across 1 directory with 3 updates #1212

Merged
merged 5 commits into from
Aug 24, 2024
Merged

chore(deps): bump the npm group across 1 directory with 3 updates #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7a7444
chore(deps): bump the npm group across 1 directory with 3 updates
dependabot[bot] Aug 23, 2024
74b80d0
chore(test): get chromium version based on nwjs version
ayushmanchhabra Aug 24, 2024
c43b4ec
chore(test): remove duplicate variable initialisation
ayushmanchhabra Aug 24, 2024
05b5e18
chore(test): fix getReleaseInfo function usage
ayushmanchhabra Aug 24, 2024
4010294
chore(test): get nw version
ayushmanchhabra Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,21 @@
"demo:exe": "./tests/fixtures/out/nwapp.app/Contents/MacOS/nwapp"
},
"devDependencies": {
"@stylistic/eslint-plugin-js": "^2.6.2",
"@stylistic/eslint-plugin-js": "^2.6.4",
"@vitest/coverage-v8": "^2.0.5",
"base-volta-off-of-nwjs": "^1.0.5",
"eslint": "^9.9.0",
"eslint-config-tjw-jsdoc": "^1.0.5",
"eslint-plugin-jsdoc": "^50.2.2",
"eslint-plugin-markdown": "^5.0.0",
"jsdoc": "^4.0.3",
"nw": "^0.90.0",
"nw": "^0.91.0",
"selenium-webdriver": "^4.23.0",
"vitest": "^2.0.4"
},
"dependencies": {
"archiver": "^7.0.1",
"axios": "^1.7.4",
"axios": "^1.7.5",
"glob": "^11.0.0",
"node-gyp": "^10.2.0",
"plist": "^3.1.0",
Expand Down
22 changes: 16 additions & 6 deletions tests/specs/osx.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,48 +9,58 @@ import { afterAll, beforeAll, describe, expect, it } from "vitest";
import setOsxConfig from "../../src/bld/osx.js";
import util from "../../src/util.js";

import nodeManifest from "../../package.json";

describe.runIf(process.platform === 'darwin')("bld/setOsxConfig", async function () {

const outDir = './tests/fixtures/macos';
const appPath = path.join(outDir, 'nwapp.app');
const releaseInfo = await util.getReleaseInfo(
nodeManifest.devDependencies.nw.split('^')[1],
util.PLATFORM_KV['darwin'],
util.ARCH_KV['arm64'],
'./node_modules/nw',
'https://nwjs.io/versions',
);
const chromiumVersion = releaseInfo.components.chromium;
const helperAlertsPath = path.join(appPath,
"Contents",
"Frameworks",
"nwjs Framework.framework",
"Versions",
"127.0.6533.73",
chromiumVersion,
"Helpers",
`nwapp Helper (Alerts).app`);
const helperGPUPath = path.join(appPath,
"Contents",
"Frameworks",
"nwjs Framework.framework",
"Versions",
"127.0.6533.73",
chromiumVersion,
"Helpers",
`nwapp Helper (GPU).app`);
const helperPluginPath = path.join(appPath,
"Contents",
"Frameworks",
"nwjs Framework.framework",
"Versions",
"127.0.6533.73",
chromiumVersion,
"Helpers",
`nwapp Helper (Plugin).app`);
const helperRendererPath = path.join(appPath,
"Contents",
"Frameworks",
"nwjs Framework.framework",
"Versions",
"127.0.6533.73",
chromiumVersion,
"Helpers",
`nwapp Helper (Renderer).app`);
const helperPath = path.join(appPath,
"Contents",
"Frameworks",
"nwjs Framework.framework",
"Versions",
"127.0.6533.73",
chromiumVersion,
"Helpers",
`nwapp Helper.app`);

Expand All @@ -75,7 +85,7 @@ describe.runIf(process.platform === 'darwin')("bld/setOsxConfig", async function
outDir: outDir,
releaseInfo: {
components: {
chromium: "127.0.6533.73",
chromium: chromiumVersion,
}
},
});
Expand Down