chore(bld): migrate from rcedit with resedit

[CosmoMyzrailGorynych]

• Replaces rcedit dependency with resedit

Why?

• rcedit is quite an ancient package that requires Wine to do anything on Linux/MacOS, and having Wine as a dependency in Linux workers sucks!
• resedit is instead a vanilla-node.js package that does not require building or external binaries.

Replacing rcedit with resedit allows cross-building Nw.js apps for Windows on mainstream Linux+Node.js container images. (Previously you would make your own to preinstall Wine.) And, of course, it makes nw-builder easier to use on Linux-based personal machines, too!

[ayushmanchhabra]

Thanks for this. I can see why you'd want to replace rcedit with resedit but doing so would introduce a breaking change to current developers workflow. I'd prefer if resedit methodology can be added alongside rcedit. After getting user feedback on both, we can assess if rcedit should be removed in v5.

[ayushmanchhabra]

Thanks for this. I can see why you'd want to replace rcedit with resedit but doing so would introduce a breaking change to current developers workflow. I'd prefer if resedit methodology can be added alongside rcedit. After getting user feedback on both, we can assess if rcedit should be removed in v5.

An option such as options.resourceEditor which defaults to rcedit can be added. Then developer has option to use resedit by explicitly setting this option to resedit.

[CosmoMyzrailGorynych]

Why would an option be needed if no API changes were introduced? вс, 19 мая 2024 г., 19:57 Ayushman Chhabra ***@***.***>:

…

Thanks for this. I can see why you'd want to replace rcedit with resedit but doing so would introduce a breaking change to current developers workflow. I'd prefer if resedit methodology can be added alongside rcedit. After getting user feedback on both, we can assess if rcedit should be removed in v5. An option such as options.resourceEditor which defaults to rcedit can be added. Then developer has option to use resedit by explicitly setting this option to resedit. — Reply to this email directly, view it on GitHub <#1094 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYG7VLTOI2B27P256GFQA3ZDDKYFAVCNFSM6AAAAABH2GDJM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGI4TSNZZGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ayushmanchhabra]

I'd prefer if resedit methodology can be added alongside rcedit.

To toggle between using rcedit and resedit.

[CosmoMyzrailGorynych]

Thanks for this. I can see why you'd want to replace rcedit with resedit but doing so would introduce a breaking change to current developers workflow.

Please explain the breaking changes here. There are no API changes and no new dependencies.

[TheJaredWilcurt]

• https://www.npmjs.com/package/resedit

The resedit package makes no claims of being a drop-in replacement for, or even having API parity with rcedit. It in fact does not even mention rcedit at all. So it would be safe to assume some form of breaking changes would be introduced.

rcedit is quite ancient

Both rcedit and resedit are actively maintained and have had new releases in the past year (November and April).

I agree with Ayush. Offering both as an option makes the most sense. Continue to default to what we have to avoid breaking changes. Re-evaluate when going to the next major in the library.

I'd like to see a more comprehensive comparison of both technologies, what features they each have, if there are any features one has the other doesn't, are there granular controls that differ, etc (other than wine which is the obvious major difference). If we could completely replace rcedit, that would be cool, I am generally in favor of tools that are cross-platform by default and don't require the dev to jump through hoops like setting up wine, or using a separate Windows VM for builds.

[CosmoMyzrailGorynych]

The resedit package makes no claims of being a drop-in replacement for, or even having API parity with rcedit.

They don't — my PR handles these differences so the end product is the same. nw-builder uses rcedit to change executable's main icon and change the version info (which includes lots of other keys like company name and copyright), and so does resedit in my PR. Icons are replaced in a correct icon group. List of keys Windows executables can have is neither up to rcedit nor up to resedit — it is constant and thus is the same for both packages.

I use resedit for my nw.js app and for neutralino.js ones, resedit does a great job in both circumstances. Disputes about keeping rcedit seems like an XY problem to me or not understanding the PR.

[ayushmanchhabra]

Sorry, misunderstood the PR. Went in depth into what resedit does/is capable of. Also went through the PR - no breaking changes.

[CosmoMyzrailGorynych]

Thank you for merging in the review changes and the PR — I was busy with my own projects and couldn't add changes in time.