Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bld): set product_string property in manifest to rename MacOS Helper apps #1290

Merged
merged 9 commits into from
Nov 1, 2024
Merged

fix(bld): set product_string property in manifest to rename MacOS Helper apps #1290

merged 9 commits into from
Nov 1, 2024
+34 −16

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Oct 31, 2024 •
edited
Loading

  • Replace special and control characters iff options.app.name is a string

Fixes: #1286

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 29.97% 506 / 1688
🔵 Statements 29.97% 506 / 1688
🔵 Functions 30% 9 / 30
🔵 Branches 63.33% 19 / 30
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/bld.js 31.44% 100% 0% 31.44% 111-196, 199-244, 247-289, 292-349, 352-361, 364-386
src/index.js 0% 0% 0% 0% 1-139
src/util.js 33.08% 78.57% 33.33% 33.08% 25-26, 34-35, 61-62, 72-74, 80-83, 114-130, 141-160, 162-164, 166-167, 175-185, 194-195, 197-206, 208-210, 212-214, 216-218, 220-221, 223-224, 226-233, 235-277, 279-296, 298-299, 309-345, 347-357, 359-371, 373-375, 377-379, 381-383, 385-394, 396-403, 405-408, 410-413, 415-417, 428-439
Generated in workflow #952 for commit a4dcbe4 by the Vitest Coverage Report Action

@ayushmanchhabra ayushmanchhabra changed the title fix(bld): insert product_string property in manifest for MacOS builds fix(bld): insert product_string property in manifest for renaming MacOS Helper apps Nov 1, 2024
@ayushmanchhabra ayushmanchhabra changed the title fix(bld): insert product_string property in manifest for renaming MacOS Helper apps fix(bld): set product_string property in manifest for renaming MacOS Helper apps Nov 1, 2024
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review November 1, 2024 07:11
@ayushmanchhabra ayushmanchhabra changed the title fix(bld): set product_string property in manifest for renaming MacOS Helper apps fix(bld): set product_string property in manifest to rename MacOS Helper apps Nov 1, 2024
@ayushmanchhabra ayushmanchhabra merged commit b1caad7 into main Nov 1, 2024
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the dev-1286 branch November 1, 2024 07:12
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
ayushmanchhabra pushed a commit that referenced this pull request Nov 1, 2024
@github-actions
chore(main): release 4.11.6 (#1291)
89f7d64 
🤖 I have created a release *beep* *boop*
---


##
[4.11.6](v4.11.5...v4.11.6)
(2024-11-01)


### Bug Fixes

* **bld:** set product_string property in manifest to rename MacOS
Helper apps ([#1290](#1290))
([b1caad7](b1caad7)),
closes [#1286](#1286)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mac OS app unable to start using 4.11.4
1 participant
@ayushmanchhabra