Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac OS app unable to start using 4.11.4 #1286

Closed
zkrige opened this issue Oct 28, 2024 · 5 comments · Fixed by #1290 or #1291
Closed

Mac OS app unable to start using 4.11.4 #1286

zkrige opened this issue Oct 28, 2024 · 5 comments · Fixed by #1290 or #1291
Assignees
@ayushmanchhabra

Comments

@zkrige
Copy link
Collaborator

zkrige commented Oct 28, 2024 •
edited by ayushmanchhabra
Loading

4.8.1 does NOT rename the helpers, but 4.11.4 does. I suspect that renaming the helpers is causing the crash
image

[82675:259:1028/090525.413358:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.413388:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 1 time(s)
[82675:259:1028/090525.414548:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.419147:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.422696:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 2 time(s)
[82675:259:1028/090525.424391:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.427924:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.427939:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 3 time(s)
[82675:259:1028/090525.428885:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.438697:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.438711:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 4 time(s)
[82675:259:1028/090525.440357:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.441828:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.444684:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 5 time(s)
[82675:259:1028/090525.445621:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.452703:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.452941:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 6 time(s)
[82675:259:1028/090525.454778:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.460886:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.460896:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 7 time(s)
[82675:259:1028/090525.461782:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.466229:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.468756:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 8 time(s)
[82675:259:1028/090525.470571:ERROR:network_service_instance_impl.cc(608)] Network service crashed, restarting service.
[82675:259:1028/090525.473138:ERROR:gpu_process_host.cc(1005)] GPU process launch failed: error_code=1003
[82675:259:1028/090525.476840:WARNING:gpu_process_host.cc(1445)] The GPU process has crashed 9 time(s)
[82675:259:1028/090525.476853:FATAL:gpu_data_manager_impl_private.cc(436)] GPU process isn't usable. Goodbye.
@ayushmanchhabra
Copy link
Collaborator

Definetely an error in renaming MacOS helpers logic. Will look into it soon.

Could you provide the nw version, node version, and options used?

@zkrige
Copy link
Collaborator Author

zkrige commented Oct 28, 2024

It fails in builder 4.11.4, node 22.7.0

it was working in 4.8.1

@ayushmanchhabra
Copy link
Collaborator

@zkrige are you using any options.app.* options? Essentially is the crash happening when no app.* options are defined?

For example, this is what I'm using to test if Helper apps are renamed:

app: {
    name: 'nwapp',
    // MacOS options
    LSApplicationCategoryType: 'public.app-category.utilities',
    CFBundleIdentifier: 'io.nwutils.demo',
    CFBundleName: 'Demo',
    CFBundleDisplayName: 'Demo',
    CFBundleSpokenName: 'Demo',
    CFBundleVersion: '0.0.0',
    CFBundleShortVersionString: '0.0.0',
    NSHumanReadableCopyright: 'Copyright (c) 2024 NW.js Utilities'
  }

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Oct 31, 2024 •
edited
Loading

Forgot to mention that to rename the helper apps, you have to add a product_string property in your NW.js manifest file. This value should be the same as the options.app.name value. For example:

  "product_string": "Demo"

@ayushmanchhabra ayushmanchhabra mentioned this issue Oct 31, 2024
Merged
@zkrige
Copy link
Collaborator Author

zkrige commented Nov 1, 2024

Sorry for the delay - I'll get on this next week again

ayushmanchhabra added a commit that referenced this issue Nov 1, 2024
@ayushmanchhabra
fix(bld): set product_string property in manifest to rename MacOS Hel…
b1caad7 
…per apps (#1290)

* Replace special and control characters iff options.app.name is a
string

Fixes: #1286
@github-actions github-actions bot mentioned this issue Nov 1, 2024
Merged
ayushmanchhabra pushed a commit that referenced this issue Nov 1, 2024
@github-actions
chore(main): release 4.11.6 (#1291)
89f7d64 
🤖 I have created a release *beep* *boop*
---


##
[4.11.6](v4.11.5...v4.11.6)
(2024-11-01)


### Bug Fixes

* **bld:** set product_string property in manifest to rename MacOS
Helper apps ([#1290](#1290))
([b1caad7](b1caad7)),
closes [#1286](#1286)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushmanchhabra ayushmanchhabra

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zkrige @ayushmanchhabra