Skip to content

Commit

Permalink
fix(bld): resolve undefined reference (#1127)
Browse files Browse the repository at this point in the history
Fixes: #1125
  • Loading branch information
ayushmanchhabra authored Jun 19, 2024
1 parent 7aa6f08 commit 006b517
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/bld.js
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,11 @@ const setWinConfig = async ({ app, outDir }) => {
await fsm.rename(path.resolve(outDir, "nw.exe"), outDirAppExe);
const exe = peLibrary.NtExecutable.from(await fsm.readFile(outDirAppExe));
const res = peLibrary.NtExecutableResource.from(exe);
// English (United States)
const EN_US = 1033;
if (app.icon) {
const iconBuffer = await fsm.readFile(path.resolve(app.icon));
const iconFile = resedit.Data.IconFile.from(iconBuffer);
// English (United States)
const EN_US = 1033;
resedit.Resource.IconGroupEntry.replaceIconsForResource(
res.entries,
// This is the name of the icon group nw.js uses that gets shown in file exlorers
Expand Down

2 comments on commit 006b517

@thisjt
Copy link
Contributor

@thisjt thisjt commented on 006b517 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to log the bug with regards to the undefined reference. Thanks for this!

image

When are we expecting this fix to propagate to the nw-builder npm package?

@ayushmanchhabra
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is present in the latest version

Please sign in to comment.