-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(README): Provide workflow_run
troubleshooting
#550
base: develop
Are you sure you want to change the base?
Conversation
Adds a troubleshooting section for users to learn about `pull_request` workflow gotcha and an example of how to get it setup. Includes information on features that presently are unsupported for this action with `workflow_run` and a workaround for PR comment and status updates in the meantime. Deployment environment updates can't be disabled and will use the wrong commit for now.
Fantastic! Thank you so much for the explanation and code. Code is very helpful. I'll read. |
@polarathene Thanks for the thorough documentation. It was quite helpful since I also had to set up Netlify deploys for PRs coming from outside collaborators (in zowe/docs-site#2913). One more tip that may be useful for others doing the same thing - in my case, the artifact for the preview build is quite large (almost 1GB) so it takes 5-10 minutes to upload it from the In order to make deployments as quick as possible, I still deploy from the Then in the |
I see you're using Docusaurus which I had experimented with prior to the team choosing EDIT: Ok, I inspected one of your workflow runs artifacts, 1GB uncompressing to 1.5GB build dir. The bulk of the fileweight is from your PDFs, GIFs and other assets that aren't likely changing often? Since these are probably part of the Git repo already, you could exclude them and restore afterwards, or use the cache action if that's simpler? It'd shave a tonne of weight. The GIF files are quite large, you could try use MP4 or AVIF depending on the audience browsers and what's easiset for you, that should help quite a bit too. You have 2-3GB webpack caches 😬 (I haven't looked into contents, depends how useful and timesaving that is as it eats into your 10GB CI cache for other items) |
Adds a troubleshooting section for users to learn about
pull_request
workflow gotcha and an example of how to get it setup.Includes information on features that presently are unsupported for this action with
workflow_run
and a workaround for PR comment and status updates in the meantime.Deployment environment updates can't be disabled and will use the wrong commit for now.