Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Promise type from web-promise library #24

Closed
thomashoneyman opened this issue Aug 11, 2021 · 5 comments
Closed

Use Promise type from web-promise library #24

thomashoneyman opened this issue Aug 11, 2021 · 5 comments

Comments

@thomashoneyman
Copy link

Do you have any interest in reusing the Promise type as exposed in the web-promise library? See:
https://github.com/purescript-web/purescript-web-promise

A bit of work has gone in to the Promise representation in that library, and it may be useful to reuse the type here. I'd like to use aff-promise in projects that are already using the type from that library, but unless I'm mistaken that's not currently possible.

@nwolverson
Copy link
Owner

Not sure there's any downside of that, the dependencies of purescript-web-promise don't look particularly heavy

(sorry I don't seem to have been watching the issues here)

@jamesdbrock
Copy link

Would you like a PR for this @nwolverson ?

@nwolverson
Copy link
Owner

nwolverson commented May 26, 2022 via email

@i-am-the-slime
Copy link

i-am-the-slime commented Aug 18, 2022

Shouldn't the web-promise library be called js-promise?

@nwolverson
Copy link
Owner

Resolved by #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants