Add Object: {Get|Set}NameByLanguage #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lecomte
force-pushed
the
local-object-setnamelanguage
branch
2 times, most recently
from
4d13fd8 to
3759bd2
Compare
Daztek
reviewed
Mar 5, 2024
julien-lecomte
force-pushed
the
local-object-setnamelanguage
branch
from
ce53061 to
9fd6bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my effort to have dual-language module, using
SetNamewill overwrite translations. For this reason, if we set the name for specific languages, and then usuallySetName(oObject, ""), the translations will be correct for all players.Their might be 3 gender values, neutral, male, and female, but experimenting with French made out to have male=0, female=1. Unsure, but I believe German might be a language with three language genders.