Enable building Node native addon via Python 3 #8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
ayushmanchhabra
changed the title
|
Can we get this merged in for upcoming v0.83? |
yes I will try to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on nwjs/node#58.
This is a follow up of #8134 which turned out to be an incorrect fix. This PR will allow nw-builder to build node native addons (directly via node-gyp using NW.js node headers) using Python 3. Since only ICU requires
v8_host_byteorder, I have moved it there. After making these changes, I am able to successfully build Node. I'm planning to submit a test case for this in a subsequent PR.