[Screen Selection] OSX and Win implementation #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [4606c6c] [Screen Selection] [OSX] initial implementation
rogerwang
added a commit
that referenced
this pull request
Mar 4, 2015
[Screen Selection] OSX and Win implementation
|
@rogerwang is it only fail for mac_32 ? |
|
@jtg-gg failed too for mac_64: http://buildbot-master.node-webkit.org:8010/builders/mac64_nw12/builds/23/steps/ninja_release/logs/stdio windows and linux passed. |
|
@rogerwang can you force a clean build on OSX ? |
|
thanks. it passed with a clean build. |
|
I add some doc here, please revise it: https://github.com/nwjs/nw.js/wiki/Screen#choosedesktopmedia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome Screen Selection does not work ubuntu linux
hence I am not yet supporting it on linux
how to use it:
var gui = require('nw.gui');
gui.Screen.Init();
gui.Screen.chooseDesktopMedia(["window","screen"],
function(streamId) {
var vid_cons = {mandatory: {chromeMediaSource: 'desktop', chromeMediaSourceId: streamId, maxWidth: 1920, maxHeight: 1080}, optional:[]};
navigator.webkitGetUserMedia({audio: false, video: vid_cons}, success_func, fallback_func);
});