Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject_js_start not working with iframes in 0.14.3 #4791

Closed
phpjishu opened this issue Apr 29, 2016 · 1 comment
Closed

inject_js_start not working with iframes in 0.14.3 #4791

phpjishu opened this issue Apr 29, 2016 · 1 comment
Assignees
@rogerwang
Milestone
0.14.x

Comments

@phpjishu
Copy link

I saw the update log on inject_js_start optimized, but the new problem is, if I embed an iframe in a page, open the page in the iframe is not correctly added inject_js_start JS files, resulting in a number of ways within the page can not be used. #4705 @rogerwang
@rogerwang rogerwang changed the title 0.14.3 appear BUG, seriously affected the original program, to solve problems as soon as possible, thank you inject_js_start not working with iframes in 0.14.3 May 3, 2016
@rogerwang rogerwang added this to the 0.14.x milestone May 3, 2016
@rogerwang rogerwang self-assigned this May 3, 2016
rogerwang added a commit that referenced this issue May 5, 2016
@rogerwang
[test] issue4791-injectend-iframe and issue4791-injectstart-iframe
ddce66d 
For #4791
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
0.14.x
Development

No branches or pull requests
2 participants
@rogerwang @phpjishu