Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to select the first application by default when pressing ENTER or the direction arrows after a search #17

Closed
gouvinb opened this issue Aug 27, 2021 · 1 comment · Fixed by #18
Labels
enhancement New feature or request

Comments

@gouvinb
Copy link
Contributor

gouvinb commented Aug 27, 2021

Description

Add an option to select the first application by default when pressing ENTER or the direction arrows after a search. Currently this scenario occurs only when launching nwg-drawer and without having done a search.

Actual result

Without search

  • Launch nwg-drawer
  • Press ENTER
  • It launches the first application in the list

And

  • Launch nwg-drawer
  • Press an arrow key
  • It moves the selection in the direction chosen from the first application in the list

With search

  • Launch nwg-drawer
  • Enter the beginning of the name of an application.
  • Press ENTER
  • This has no effect

And

  • Launch nwg-drawer
  • Enter the beginning of the name of an application.
  • Press an arrow key
  • It moves the selection in the direction chosen from the searchbar

Expected result

Without search

Keep the current scenario.

With search

  • Launch nwg-drawer
  • Enter the beginning of the name of an application.
  • Press ENTER
  • Run the first application in the list

And

  • Launch nwg-drawer
  • Enter the beginning of the name of an application.
  • Press an arrow key
  • Move the selection in the direction chosen from the first application in the list
@nwg-piotr nwg-piotr added the enhancement New feature or request label Aug 27, 2021
@nwg-piotr
Copy link
Owner

For this to be visible / intuitive, the first search result should grab focus. I'll take a closer look at it tonight.

nwg-piotr added a commit that referenced this issue Aug 29, 2021
nwg-piotr added a commit that referenced this issue Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants