Fixed bugs in _redoMove()
and _undoMove()
#15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En Passant move
An inconsistency may be created by performing
undoMove()
andredoMove()
several times.For example: Let a game starts with the following moves: e2->e4, f7->f5, e4->f5.
Then, let's perform
undoMove
andredoMove
. Then check the available moves for black pawn in g7. An inconsistency may be expected.Reason: In private function
_redoMove()
, we calls_execute(uncheckedMove: promotion:)
and passes the move that will be redone. But the propertyenPassantMove
has not been updated in_redoMove
. So there will be an inconsistency in the future calls performed on the game.Solution: Updates the
enPassantMove
in_redoMove()
.King is checked
kingIsChecked
may returns the wrong value.Reason: This is caused by copying a wrong value to
_undoHistory
in the function_undoMove()
.Solution: Pass the correct value to
_undoHistory.append(:)
.