nvm use: perfect pre-npm-config env var checking
#1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
the
performance
ljharb
force-pushed
the
nvm_npm_prefix
branch
2 times, most recently
from
ecc445a
to
5dddeef
Compare
zkat
approved these changes
Dec 9, 2017
ljharb
force-pushed
the
nvm_npm_prefix
branch
from
5dddeef
to
4846d57
Compare
|
<3 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zkat @iarna: I would dearly love your input on this change; if this env var checking is good, then I can next replace
npm config get prefixwith "searching .npmrc files", which will give nvm a huge performance boost.