Fix stall when pynini is imported before this library #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, doing this: import pynini import riva.asrlib.decoder would end in a stall. This was because the FlagRegister template class had a static variable Mutex, that ended up being shared by default in the global symbol namespace. Because the openfst versions are different between the two libraries (I think pynini's openfst 1.8.2 uses absl::Mutex), the mutex layouts are different, probably causing the stall. We don't want the symbols to be shared in this case, so we disable unique symbols via "-fno-gnu-unique".
Helps with flaky CI failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, doing this:
import pynini
import riva.asrlib.decoder
would end in a stall. This was because the FlagRegister template class had a static variable Mutex, that ended up being shared by default in the global symbol namespace. Because the openfst versions are different between the two libraries (I think pynini's openfst 1.8.2 uses absl::Mutex), the mutex layouts are different, probably causing the stall.
We don't want the symbols to be shared in this case, so we disable unique symbols via "-fno-gnu-unique".