Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak add throughput tests #20

Merged
merged 12 commits into from
Mar 23, 2023
Merged

Fix memory leak add throughput tests #20

merged 12 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Test throughput performance

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b1df247 View commit details
    Browse the repository at this point in the history

  2. Add some extra utilities. 

    I may remove them later.
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    61ad69c View commit details
    Browse the repository at this point in the history

  3. Add unit test for comparing NeMo and flashlight.

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4a46465 View commit details
    Browse the repository at this point in the history

  4. Fix nbest list support. 

    Previously, it would always return an empty list.

Add support for blank penalty and length penalty, as wenet has them.
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a46eab4 View commit details
    Browse the repository at this point in the history

  5. Save work before trying nanobind.

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ce89475 View commit details
    Browse the repository at this point in the history

  6. Change to nanobind. 

    Fix GPU memory leak. My pybind11 DLPack integration was incorrect.
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    bce1785 View commit details
    Browse the repository at this point in the history

  7. Fix memory leak by using "class scope" fixture. 

    Previously, 5 GiB were being created for every test because the
librispeech test and dev sets were being loaded every time.
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    0be485a View commit details
    Browse the repository at this point in the history

  8. Add WER unit tests for alternate topologies other than Eessen. 

    Minor cleanup.
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    376ffb6 View commit details
    Browse the repository at this point in the history

  9. Add throughput tests. 

    We don't check that RTFx is the same right now. It might be too
flakey.

Recorded throughput results here: #19
    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    1ad3b5e View commit details
    Browse the repository at this point in the history

  10. Remove dlpack pybind11 type caster.

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ae50356 View commit details
    Browse the repository at this point in the history

  11. clang-format, black format, isort

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8a8bbd3 View commit details
    Browse the repository at this point in the history

  12. Remove useless commented out test.

    @galv
    galv committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    bb74d1e View commit details
    Browse the repository at this point in the history