[1269] Prevent dropping elements in a read only diagram

Bug: eclipse-sirius#1269 Signed-off-by: Nicolas Vannier <nicolas.vannier@obeo.fr>
nvannr · Jun 14, 2022 · d24c074 · d24c074
1 parent c5e9ca6
commit d24c074
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -18,6 +18,7 @@
 - https://github.com/eclipse-sirius/sirius-components/issues/1253[#1253] [studio] Fix the computation of unsynchronized semantic elements in studios (which broke the use of the Create View operation)
 - https://github.com/eclipse-sirius/sirius-components/issues/1193[#1193] [layout] Fix edge layout on diagrams with node lists.
 - https://github.com/eclipse-sirius/sirius-components/issues/1260[#1260] [workbench] Fix download project fails when model contains a Form Description Editor
+- https://github.com/eclipse-sirius/sirius-components/issues/1269[#1269] [diagram] Prevent dropping elements in a read only diagram
 
 === Improvements
 

diff --git a/frontend/src/diagram/DropArea.tsx b/frontend/src/diagram/DropArea.tsx
@@ -58,6 +58,7 @@ export const DropArea = ({
   invokeHover,
   convertInSprottyCoordinate,
   children,
+  readOnly,
 }: DropAreaProps) => {
   const [{ value, context }, dispatch] = useMachine<DropAreaContext, DropEvent>(dropAreaMachine);
   const { toast } = value as SchemaValue;
@@ -141,17 +142,25 @@ export const DropArea = ({
 
   const handleDrop = (event) => {
     event.preventDefault();
-    const dragSourcesStringified = event.dataTransfer.getData(DRAG_SOURCES_TYPE);
-    if (dragSourcesStringified) {
-      const sources = JSON.parse(dragSourcesStringified);
-      if (Array.isArray(sources)) {
-        const sourceIds = sources.filter((source) => source?.id).map((source) => source.id);
-        if (sourceIds.length > 0) {
-          const diagramElementId = searchId(event.target);
-          if (diagramElementId) {
-            dropElement(sourceIds, event.clientX, event.clientY, diagramElementId);
-          } else {
-            dropElement(sourceIds, event.clientX, event.clientY);
+    if (readOnly) {
+      const showToastEvent: ShowToastEvent = {
+        type: 'SHOW_TOAST',
+        message: 'You do not have permission to edit this representation',
+      };
+      dispatch(showToastEvent);
+    } else {
+      const dragSourcesStringified = event.dataTransfer.getData(DRAG_SOURCES_TYPE);
+      if (dragSourcesStringified) {
+        const sources = JSON.parse(dragSourcesStringified);
+        if (Array.isArray(sources)) {
+          const sourceIds = sources.filter((source) => source?.id).map((source) => source.id);
+          if (sourceIds.length > 0) {
+            const diagramElementId = searchId(event.target);
+            if (diagramElementId) {
+              dropElement(sourceIds, event.clientX, event.clientY, diagramElementId);
+            } else {
+              dropElement(sourceIds, event.clientX, event.clientY);
+            }
           }
         }
       }

diff --git a/frontend/src/diagram/DropArea.types.ts b/frontend/src/diagram/DropArea.types.ts
@@ -18,4 +18,5 @@ export interface DropAreaProps {
   invokeHover: (id: string, mouseIsHover: boolean) => void;
   convertInSprottyCoordinate: (x: number, y: number) => Promise<{ x: number; y: number }>;
   children: React.ReactNode;
+  readOnly: boolean;
 }