Send logdna now argument in milliseconds #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,6 +80,11 @@ public function setTags($tags) | |||
| $this->tags = $tags; | |||
| } | |||
|
|
|||
| public function setIncludeRequestTime($include) | |||
There was a problem hiding this comment.
Missing @param documentation.
| @@ -128,4 +143,11 @@ protected function getDefaultFormatter(): FormatterInterface | |||
| { | |||
| return new \Zwijn\Monolog\Formatter\LogdnaFormatter(); | |||
| } | |||
|
|
|||
| private function getCurrentTimeInMilliseconds(): string | |||
There was a problem hiding this comment.
I would just remove this function or replace it's content with
return (string)floor(microtime(true) * 1000);
| @@ -108,6 +118,11 @@ protected function write(\Monolog\LogRecord $record): void | |||
| 'ip' => $this->ip, | |||
| 'tags' => $this->tags | |||
| ]; | |||
|
|
|||
| if ($this->include_request_time) { | |||
| $query['now'] = $this->getCurrentTimeInMilliseconds(); | |||
There was a problem hiding this comment.
We could replace this with just (string)floor(microtime(true) * 1000).
|
I was originally concerned that floating point arithmetics might not be suitable here, but
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussedi in #21 this implementation takes the now value from system time and sends it to logdna in milliseonds as per documentation (https://docs.mezmo.com/log-analysis-api#ingest)
I also added the possibility to turn the time drift calculation off by not sending the now parameter