Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: fix-up changes for UIA by default #13828

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

codeofdusk
Copy link
Contributor

Link to issue number:

Fix-up of #10964.

Summary of the issue:

Description of how this pull request fixes the issue:

Updates changes.

Testing strategy:

Checked t2t output.

Known issues with pull request:

I wasn't sure how to override the t2t preproc directive to write a raw hash symbol for the microsoft/terminal PR, so I didn't use it. Feel free to amend with an escaped hash.

Change log entries:

N/A

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@codeofdusk codeofdusk requested a review from a team as a code owner June 21, 2022 19:33
@codeofdusk codeofdusk requested a review from seanbudd June 21, 2022 19:33
@codeofdusk codeofdusk force-pushed the cmduia-fixup-changes-for-default branch from 4e0ac42 to 0c2fcf9 Compare June 21, 2022 19:36
This commit fixes the link to the microsoft/terminal PR and adds a note to help users check their API level. I wasn't sure how to override the t2t preproc directive to write a raw hash symbol for the microsoft/terminal PR, so I didn't use it. Feel free to amend with an escaped hash.
@codeofdusk codeofdusk force-pushed the cmduia-fixup-changes-for-default branch from 0c2fcf9 to c4073a6 Compare June 21, 2022 19:38
@codeofdusk

This comment was marked as resolved.

@codeofdusk

This comment was marked as resolved.

@seanbudd seanbudd self-assigned this Jun 22, 2022
@seanbudd seanbudd merged commit 506f306 into nvaccess:master Jun 22, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.3 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants