Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changes.t2t to fix listings for results of PR#11782 #12444

Merged
merged 2 commits into from
May 21, 2021

Conversation

XLTechie
Copy link
Collaborator

@XLTechie XLTechie commented May 20, 2021

Link to issue number:

None

Summary of the issue:

The changes for PR #11782 were listed twice, and with slight differences between the two.
Because this is an important change, I thought it should be more clear than that. @feerrenrut agreed in #12416 (comment) that this might be a reasonable fix at this time.

Description of how this pull request fixes the issue:

Selected the best of the possible descriptions of what this PR changed, and organized them appropriately.
Changed a few words to improve clarity.

Testing strategy:

Read the results and saw that they were good.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

…fferently. Picked the best lines from both.
@XLTechie XLTechie marked this pull request as ready for review May 20, 2021 16:23
@XLTechie XLTechie requested a review from a team as a code owner May 20, 2021 16:23
@XLTechie XLTechie requested review from seanbudd and removed request for a team May 20, 2021 16:23
@seanbudd seanbudd requested a review from feerrenrut May 20, 2021 23:44
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XLTechie

@feerrenrut feerrenrut merged commit 922957b into nvaccess:beta May 21, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.2 milestone May 21, 2021
@feerrenrut feerrenrut modified the milestones: 2021.2, 2021.1 May 21, 2021
@XLTechie XLTechie deleted the duplicateInChanges branch May 21, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants