Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up #11969: Fixed case issue. #12015

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

CyrilleB79
Copy link
Collaborator

Link to issue number:

Fixes #12014
Fixes #12013
Fix-up of #11969

Summary of the issue:

In #11969, a typo has been introduced: "Focus" (title case) instead of "FOCUS" (upper case)

Description of how this pull request fixes the issue:

Fixed the typo

Testing performed:

Called NVDA+F where I have also seen this issue.

Known issues with pull request:

None

Change log entry:

None: fix-up in alpha stage.

@lukaszgo1
Copy link
Contributor

@CyrilleB79 Many thanks for cleaning my mess :-)

@AppVeyorBot
Copy link

See test results for failed build of commit 4a8c35b4ef

@CyrilleB79
Copy link
Collaborator Author

The system tests has failed. However, I do not know why.
Any idea from someone else?

@lukaszgo1
Copy link
Contributor

I don't think system test failure is related to your changes - this particular test simply fails intermittently.

@michaelDCurran
Copy link
Member

When reviewing this time, I confirmed with grep that there are no other references to OutputReason members containing lowercase.: "OutputReason.[a-zA-Z]*[a-z]"

@michaelDCurran michaelDCurran merged commit 94e2926 into nvaccess:master Jan 31, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Jan 31, 2021
@CyrilleB79 CyrilleB79 deleted the fixUp11969) branch February 1, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants