Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review cursor in console does not move as expected in NVDA 2019.3beta1 #10618

Closed
CyrilleB79 opened this issue Dec 13, 2019 · 24 comments
Closed

Comments

@CyrilleB79
Copy link
Collaborator

Steps to reproduce:

  • Open Windows console (cmd)
  • Press Numpad8 to read current line
    You can hear "C:\Users\myLogin>"
  • Press Numpad4 many times to go back word by word
    You can hear successfully ":\User", "blank", " réservés"
    Note: on my French Windows the non empty line before the prompt is the following:
    (c) 2018 Microsoft Corporation. Tous droits réservés.
  • Press Numpad6 to go forward word by word
    You are stuck on "" réservés" word

Note : playing with word by word and line by line navigation, you will find many other navigation issues. I do not list them all here.

Actual behavior:

  • The "c:" word was skipped
  • Going forward you are stuck at end of line.

Expected behavior:

Navigation with review cursor should behave in UIA Console as it did in legacy. This means:

  • No word should be skipped when navigating by word
  • Pressing Numpad4 and then Numpad6 should perform symmetrical actions, i.e. Numpad6 after Numpad4 should turn back to current reviewed word
  • Idem with Numpad7 and Numpad9
  • After having navigated line by line, pressing Numpad6 says "bottom" even if it is not the last line. This should not happen.
  • etc.

As an alternative if this cannot be fixed, UIA should not be activated by default in console.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

NVDA 2019.3beta3

Windows version:

Windows 10 - Version 1809 (version du système d'exploitation 17763.864)

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

No other NVDA version. However, with legacy console, all is fine.

@CyrilleB79
Copy link
Collaborator Author

Cc @codeofdusk

@LeonarddeR
Copy link
Collaborator

I can not reproduce this with the latest alpha on Windows 10 2004 insider preview.

@codeofdusk
Copy link
Contributor

Possibly related to #10562.

@CyrilleB79
Copy link
Collaborator Author

On home computer (Win 10 1903 instead of 1809 at work), I do not reproduce the same way as at work. Anyway, I have other similar problem.
I try to go word by wor back untill the top of a newly opened console. When I have reached the beginning of the top line
Microsoft Windows [version 10.0.18362.535]
I am stuck on the Microsoft word and cannot go forward on the next word (Windows)

@lukaszgo1
Copy link
Contributor

cc @michaelDCurran It would be good to decide if we still should make UIA enabled for terminals by default.

@CyrilleB79
Copy link
Collaborator Author

Here is a log where I perform the following actions:

  • Press Windows+R, type "cmd" and press Enter to open the console
  • Press many times Pavnum4 until I hear the word "réservés"
  • Press Pavnum6 to try to go at the next word (failing)

nvda-ConsoleNavigation.log

@codeofdusk , @lukaszgo1:
Did you succeed in reproducing this issue?

Other questions: Could this be due to localisations? I am using Windows in French and default French code page 850 in the console.
I have tried to change the code page to CP437 (English) and clear the text ("cls" command) to avoid text with non ASCII characters ("é" in the word "réservé"). However this does not solve the issue.

This log was performed with Windows 10 1809 (Microsoft Windows [version 10.0.17763.864])

@lukaszgo1
Copy link
Contributor

@CyrilleB79 I cannot reproduce this problem on my VM running English version of Windows 10 1903.
Is it at all possible for you to install and switch to English language pack at least on the home system?

@lukaszgo1
Copy link
Contributor

I've installed French laguage pack on my VM, but I am still unable to reproduce this.

@CyrilleB79
Copy link
Collaborator Author

I have just tried setting Windows UI to English and NVDA also switch to English due to "User default" language option selected. The issue is still reproduced on my side the same way as described in the initial description, replacing the French word "réservé" by the English one "reserved".

I cannot figure why I get this issue at home and at work whereas you @LeonarddeR and @lukaszgo1 do not experience this issue.

@LeonarddeR is running Windows insider preview. I am running 1809 at work and 1903 at home. @lukaszgo1 which Win10 version are you running? Could this make a difference?

@lukaszgo1
Copy link
Contributor

I have Windows 10 version 1903 running on my VM.

@CyrilleB79
Copy link
Collaborator Author

I have found that the commit responsible for this strange behaviour is 3cd482f from PR #10522: it is the first commit of master branch where the problem occurs. However I still do not have any idea of the reason why it occurs on my side and not on other people's machine.

@michaelDCurran or other people, could you investigate further? The word boundaries are not detected correctly on my side and I think this is the reason why navigation by word get stuck at some points.

Note that the issue makes the use of review cursor impossible for me in the console. IMO, NVDA 2019.3 should really not ship with this issue.

@RudolfWeeber
Copy link

I have a related issue With 2019.3beta1; On the braille display, the cursor does not advance when typing spaces after the last letter.
Example: run Ubuntu in wsl, type 'ls ' not including the quotes on the prmopt. On the braille display, the line reads 'ls' without the final space. The issue goes away when choosing "prefer legacy" for Windows console in advanced settings.

@codeofdusk
Copy link
Contributor

codeofdusk commented Apr 2, 2020

I try to go word by wor back untill the top of a newly opened console. When I have reached the beginning of the top line
Microsoft Windows [version 10.0.18362.535]
I am stuck on the Microsoft word and cannot go forward on the next word (Windows)

I can reproduce this in the 1909 console with UIA enabled, but not in Open Console, so it seems that using Microsoft's new native UIA word navigation fixes this issue.

@codeofdusk
Copy link
Contributor

I have a related issue With 2019.3beta1; On the braille display, the cursor does not advance when typing spaces after the last letter.
Example: run Ubuntu in wsl, type 'ls ' not including the quotes on the prmopt. On the braille display, the line reads 'ls' without the final space. The issue goes away when choosing "prefer legacy" for Windows console in advanced settings.

I don't currently have a Braille display with me, but I'd imagine this issue is fixed with end exclusive text ranges in the console (i.e. microsoft/terminal#4018).

@codeofdusk
Copy link
Contributor

This is upstream issue microsoft/terminal#3976.

@codeofdusk
Copy link
Contributor

Microsoft (especially @carlos-zamora) have done a lot of really great work on UIA console for the next version of Windows (21H1). We'd really like UIA to become the default again in a future NVDA/Windows release, assuming these bugs have been resolved.

Could people who have experienced UIA issues please download this build (extract the zip and run OpenConsole.exe), re-enable UIA in console in NVDA advanced prefs, and report back if:

  • @CyrilleB79 UIA now has native word navigation, could you please verify that it works as you expect in this build?
  • @RudolfWeeber Does Braille work as you expect?

A timely response would be appreciated so that these bugs can be fixed in the next version of Windows. Thanks!

@akash07k
Copy link

akash07k commented Oct 4, 2020

Should we try it with latest NVDA alpha or any specific NVDA try build is there?

Microsoft (especially @carlos-zamora) have done a lot of really great work on UIA console for the next version of Windows (21H1). We'd really like UIA to become the default again in a future NVDA/Windows release, assuming these bugs have been resolved.

Could people who have experienced UIA issues please download this build (extract the zip and run OpenConsole.exe), re-enable UIA in console in NVDA advanced prefs, and report back if:

* @CyrilleB79 UIA now has native word navigation, could you please verify that it works as you expect in this build?

* @RudolfWeeber Does Braille work as you expect?

A timely response would be appreciated so that these bugs can be fixed in the next version of Windows. Thanks!

@codeofdusk
Copy link
Contributor

Should we try it with latest NVDA alpha or any specific NVDA try build is there?

Latest alpha should be okay, but be aware of #11722.

@codeofdusk
Copy link
Contributor

Actually, this build contains a fix for the issue mentioned in #11722 as well.

@akash07k
Copy link

akash07k commented Oct 4, 2020 via email

@Adriani90
Copy link
Collaborator

@akash07k have you tested with last NVDA alpha? Is this issue still occuring?

@akash07k
Copy link

I can't reproduce this issue with the latest conhost and NVDA alpha

@akash07k have you tested with last NVDA alpha? Is this issue still occuring?

@Adriani90
Copy link
Collaborator

Thank you for the update. I am closing this one as works for me.

@codeofdusk
Copy link
Contributor

I have tested both reported issues. I can reproduce them pre-21H1, and can report that they have been fixed in the 21H1 console. Thanks @carlos-zamora!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants