-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for Review] Add Morphues dfp #5
[Ready for Review] Add Morphues dfp #5
Conversation
(needs single file due to a nextjs issue being unable to maintain one instance of a module)
99155af
to
320668a
Compare
@efajardo-nv @exactlyallan this is pretty much ready now. Feel free to try it out. |
I'd say this is ready to be merged, barring improvements to the Readme file, which always has scope to be better :) |
Please add this section the the README under Configuration File:
|
@AjayThorve found some issues: README fixes:
App fixes
|
@exactlyallan, I fixed/implemented all of the above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have a couple of comments:
- Can we convert this to a VS Code multi-root workspace? Will help with organization as more visualizations are added over time. This way we can have global as well as local settings for each viz
- Why are the main folders prefixed with
morpheus-
? Seems a bit redundant to havemorpheus-visualizations/morpheus-DFP
andmorpheus-visualizations/morpheus-GraphVis
. Can we just make theseDFP
andGraphVis
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Approved.
Production DFP pipeline that uses new post-processing stage to generate input for DFP Visualization UI: - `DFPVizPostprocStage` that selects columns from DFP output required by UI. Post-processing output is saved to multiple files where each corresponds to a specified time period (default is day). - Python scripts for running viz pipeline for Azure and Duo. - README with instructions for setting up environment and running DFP viz pipelines and UI for Azure and Duo. Depends on nv-morpheus/morpheus-visualizations#5 Closes #321 Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #439
This PR aims to create a directory structure for the various morhpheus visualization applications
cc @efajardo-nv @exactlyallan
Closes #3
Closes #4