Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build with MRC breaking changes #998

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

MRC PR nv-morpheus/MRC#328 had some breaking changes. While minimal, they needed to be reflected in the Morpheus build.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 26, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 26, 2023 18:10
@dagardner-nv
Copy link
Contributor

dagardner-nv commented Jun 26, 2023

I'm still getting an undefined symbol error when I configure with -DMORPHEUS_PYTHON_BUILD_STUBS=ON:

cmake -B build -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_MESSAGE_CONTEXT_SHOW=ON -DMORPHEUS_USE_CLANG_TIDY=OFF -DMORPHEUS_BUILD_TESTS=ON -DMORPHEUS_USE_CCACHE=ON -DMORPHEUS_PYTHON_INPLACE_BUILD=ON -DMORPHEUS_USE_CONDA=ON -DMORPHEUS_BUILD_EXAMPLES=ON .
cmake --build build
[320/330] Building stub for python module morpheus._lib.cudf_helpers...
FAILED: morpheus/_lib/cudf_helpers/__init__.pyi /home/dagardner/work/morpheus/build/morpheus/_lib/cudf_helpers/__init__.pyi 
cd /home/dagardner/work/morpheus/build && /home/dagardner/work/conda/envs/morpheus/bin/python3.10 -m pybind11_stubgen morpheus._lib.cudf_helpers --no-setup-py --log-level WARN -o ./ --root-module-suffix ""
Traceback (most recent call last):
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/site-packages/pybind11_stubgen/__main__.py", line 4, in <module>
    main()
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/site-packages/pybind11_stubgen/__init__.py", line 946, in main
    _module = ModuleStubsGenerator(_module_name)
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/site-packages/pybind11_stubgen/__init__.py", line 711, in __init__
    self.module = importlib.import_module(module_or_module_name)
  File "/home/dagardner/work/conda/envs/morpheus/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/dagardner/work/morpheus/build/morpheus/_lib/__init__.py", line 14, in <module>
    from . import common
ImportError: /home/dagardner/work/morpheus/build/morpheus/_lib/libmorpheus.so: undefined symbol: _ZN3mrc8internal7segment8IBuilder12add_runnableERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt10shared_ptrINS_8runnable10LaunchableEE

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit aa8f442 into nv-morpheus:branch-23.07 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants