Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in CompareDataFrameStage #935

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Fixes intermittent segfault in CompareDataFrameStage and ValidationStage

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner May 2, 2023 17:03
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels May 2, 2023
morpheus/stages/output/compare_dataframe_stage.py Outdated Show resolved Hide resolved
morpheus/stages/output/compare_dataframe_stage.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if get_messages should return a copy of the message array rather than an instance of it...

@dagardner-nv
Copy link
Contributor Author

I wonder if get_messages should return a copy of the message array rather than an instance of it...

I considered that, but decided against it since:

  1. It would come at a higher cost.
  2. Calling clear should be self descriptive.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4cec922 into nv-morpheus:branch-23.07 May 2, 2023
@dagardner-nv dagardner-nv deleted the david-fix-compare-df-stage-934 branch May 2, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants