Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary quotes from CMAKE_ARGS expression #930

Merged
merged 2 commits into from
May 1, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented May 1, 2023

Fixes a bug where CMAKE_ARGS was being enclosed in extra quotes, causing CMAKE_ARGS to be evaluated a single filename, which was not found.

Closes #906

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels May 1, 2023
@cwharris cwharris requested a review from a team as a code owner May 1, 2023 17:40
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me

@cwharris
Copy link
Contributor Author

cwharris commented May 1, 2023

/merge

@rapids-bot rapids-bot bot merged commit cd63b49 into nv-morpheus:branch-23.07 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: CMAKE_ARGS env variable set in the dev container causes the build to fail
2 participants