-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests for examples with custom stages #885
Merged
rapids-bot
merged 90 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-test-examples
Apr 28, 2023
Merged
Create tests for examples with custom stages #885
rapids-bot
merged 90 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-test-examples
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed out here since the original is large and not part of the dataset pulled by the test stage in CI
…ased-hash.txt to the version in the morpheus/data dir
This reverts commit 7c3a2bd.
…with just the id2label actually used by LogParsingPostProcessingStage
…avid-test-examples [no ci]
…avid-test-examples
mdemoret-nv
requested changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions:
- Make the
tests/examples
directory better mirror theexamples
directory- Since there are no python files in the root of
examples
, there shouldnt be any tests in the root oftests/examples
- Move any of the
tests/examples/test_XXX.py
file in the root oftests/examples
into a folder to matchexamples/XXX
- i.e.
tests/examples/test_pass_thru.py
->tests/examples/developer_guide/test_pass_thru.py
- Since there are no python files in the root of
- Make the
tests/tests_data/examples
directory better mirror theexamples
directory- Same as the previous comment. Things like
tests/tests_data/examples/abp_pcap.jsonlines
should be moved totests/tests_data/examples/abp_pcap_detection/abp_pcap.jsonlines
- Same as the previous comment. Things like
…avid-test-examples
…s into david-test-examples
…avid-test-examples
3 tasks
mdemoret-nv
approved these changes
Apr 28, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates at least one test for each example containing custom stages.
This PR currently only covers those examples which do not require additional packages.
Part of #849.
morpheus/data
dir, no longer requiring them to be fetched from LFS and making them available to unittests.examples/log_parsing/inference.py
bert-base-cased-hash.txt
andbert-base-uncased-hash.txt
files, replacing them with symlinks to the files in the morpheus/data` dir fixes [FEA]: Remove redundant bert hash files #850encoding='UTF-8'
inexamples/log_parsing/postprocessing.py
as a work-around for issue [BUG]: cupy, and by extension cudf changes the system's preferred encoding to ANSI_X3.4-1968 #859py::kw_only
to Python bindings forTensorMemory
and sublasses to ensure parity with Python impls.repr=False
for thetensors
field ofTensorMemory
avoids bug when printing due to the fact that we assign the value toself._tensors
manual_seed
method.reload_modules
fixture, requesting a reload of multiple modules should be done with@pytest.mark.reload_modules([mod1, mod2])
not callingreload_modules
twice.tests/tests_data/log_parsing
is based upon the first 5 rows of data frommodels/datasets/validation-data/log-parsing-validation-data-input.csv
Checklist